Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counting impressions based using distinct play_id instead of page_view_id #72

Open
matus-tomlein opened this issue Jun 13, 2024 · 0 comments
Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@matus-tomlein
Copy link
Contributor

Describe the bug

Impressions in the media base table are counted as the number of distinct page views. However, this is imprecise as there may be multiple videos per page, which then leads to the play rate being higher than 1 (the number of plays is more than the number of page views).

Expected results

A better solution would be to use the number of distinct play_id as the number of impressions. This would take into account all the loaded videos on the page.

@matus-tomlein matus-tomlein added the type:bug Bugs or weaknesses. The issue has to contain steps to reproduce. label Jun 13, 2024
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Development

No branches or pull requests

1 participant