Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-fs2: make the graceful shutdown return a Stream[F, Unit] instead of F[Unit] #645

Open
benjben opened this issue Jun 24, 2022 · 0 comments
Open

common-fs2: make the graceful shutdown return a Stream[F, Unit] instead of F[Unit] #645

benjben opened this issue Jun 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@benjben
Copy link
Contributor

benjben commented Jun 24, 2022

The function orchestrating enrich returns a F[Unit] instead of a Stream[F, Unit].

This results in using .compile.drain in 2 different places (here and here) instead of once.

Streaming transformer does it well.
@benjben benjben added the enhancement New feature or request label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjben