Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --validate command to validate factfiles #38

Closed
ninjabear opened this issue Apr 11, 2016 · 6 comments
Closed

Add --validate command to validate factfiles #38

ninjabear opened this issue Apr 11, 2016 · 6 comments
Assignees

Comments

@ninjabear
Copy link
Contributor

No description provided.

@ninjabear ninjabear self-assigned this Apr 11, 2016
@ninjabear
Copy link
Contributor Author

This could also be "dry-run"

@alexanderdean
Copy link
Member

Instead of a --validate, I'd probably go for the Docker/AWS CLI approach of sub-commands, so:

factotum run
factotum validate
factotum ...

Kind of thing. This gives a lot more space for the tool to "grow" than adding more and more opt flags...

@alexanderdean
Copy link
Member

To me validate and dry-run are slightly different:

  1. A validate is the kind of thing you might add into CI (i.e. it's machine-friendly)
  2. A dry-run would validate but would also step through the tasks and "pretend" to run them. I'd imagine that's more useful for a human trying to visually verify their DAG

@ninjabear
Copy link
Contributor Author

Agree with both your comments - my thoughts with "dry-run" were that for in order for it to complete, it has to be valid too - but it'd be nice to split them up for those two use cases

@alexanderdean
Copy link
Member

Hasn't this been done @ninjabear ?

@ninjabear
Copy link
Contributor Author

Hey @alexanderdean ! This is a duplicate of #68, it has been done there. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants