Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "transition" information to webhook output #82

Closed
ninjabear opened this issue Oct 21, 2016 · 4 comments
Closed

Add "transition" information to webhook output #82

ninjabear opened this issue Oct 21, 2016 · 4 comments
Assignees
Milestone

Comments

@ninjabear
Copy link
Contributor

Splitting up updates into "task_updates" and "job_updates".

Job updates contain the previous state, and the current state (this change is the reason the event was emitted) (e.g. RUNNING->SUCCEEDED)

Task updates contain a list of task transitions (the reason for the event to be emitted) e.g. RUNNING->SUCCEEDED_NO_OP

@ninjabear ninjabear added this to the Version 0.3.0 milestone Oct 21, 2016
@ninjabear
Copy link
Contributor Author

Essential as part of #59

@alexanderdean
Copy link
Member

Is this a ticket @ninjabear - the webhook is new in 0.3.0, so isn't this just part of the #59 commit?

@ninjabear
Copy link
Contributor Author

In between this and the commit for #59 the code went through a linter, so it's going to be really hard to put this back there.

I think given that, this is the best way to represent the series of events that happened to the code-base

@alexanderdean
Copy link
Member

Okay, fair play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants