Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize bad stream eagerly rather than lazily #18

Closed
fblundun opened this issue May 14, 2015 · 1 comment
Closed

Initialize bad stream eagerly rather than lazily #18

fblundun opened this issue May 14, 2015 · 1 comment
Assignees
Milestone

Comments

@fblundun
Copy link
Contributor

https://github.com/snowplow/kinesis-s3/blob/master/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis/s3/sinks/KinesisSink.scala#L77

Originally this was so that the app wouldn't create the bad stream until it became necessary. But now that we have snowplow/snowplow#1529, the lazy val just means that if the stream doesn't exist, that error won't be caught immediately.

@alexanderdean
Copy link
Member

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants