Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate onlyTrackLabelledScreens option #401

Closed
AlexBenny opened this issue Jul 2, 2020 · 0 comments
Closed

Deprecate onlyTrackLabelledScreens option #401

AlexBenny opened this issue Jul 2, 2020 · 0 comments
Assignees
@AlexBenny
Labels
priority:high To fix as soon as possible. status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
1.5.0

Comments

@AlexBenny
Copy link
Contributor

As reported in #400 the autotrackingScreenView feature API seems to have an option onlyTrackLabelledScreens that is not used anywhere.

It's part of a feature we planned but we haven't implemented yet. It's probably ended up in the public API for mistake.

We prefer to remove it from the interface in order to reimplement the feature properly once the tracker v.2.0 is released.
@AlexBenny AlexBenny added type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. status:completed Completed - but might not be released yet. priority:high To fix as soon as possible. labels Jul 2, 2020
@AlexBenny AlexBenny added this to the 1.5.0 milestone Jul 2, 2020
@AlexBenny AlexBenny self-assigned this Jul 2, 2020
@AlexBenny AlexBenny changed the title Remove onlyTrackLabelledScreens option Deprecate onlyTrackLabelledScreens option Jul 2, 2020
@AlexBenny AlexBenny mentioned this issue Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexBenny AlexBenny

Labels
priority:high To fix as soon as possible. status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@AlexBenny