New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in tests #19

Closed

colmsnowplow opened this issue Apr 26, 2022 · 0 comments

Assignees

Collaborator

colmsnowplow commented Apr 26, 2022

We enabled this configuration, thinking that it would make unicode characters more consistent with the other analytics SDKs.

This turned out not to be the case, a fact which we missed because we're using the default JSON library in our tests, which also leaves chevrons as unicode.

We should address this, and use comparisons with hardcoded values to ensure that we don't make similar mistakes in future.

colmsnowplow mentioned this issue

Ensure unicode characters are interpreted as desired #20

Closed

TiganeteaRobert self-assigned this

colmsnowplow mentioned this issue

Ensure unicode characters are interpreted as desired (closes #20) #21

Closed

TiganeteaRobert closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment