Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide control over setting the client_id in common event #26

Closed
adatzer opened this issue Oct 11, 2022 · 1 comment
Closed

Provide control over setting the client_id in common event #26

adatzer opened this issue Oct 11, 2022 · 1 comment

Comments

@adatzer
Copy link
Contributor

adatzer commented Oct 11, 2022

Currently the client_id is populated by domain_userid or by mobile_context's user id, if exists. There are may be events where none of them exists (e.g. a server-side tracked event), so this results in client_id being undefined. Since client_id is a property that downstream tags could count upon, we could provide an option to override the default client_id setting logic to better support those use cases.

@adatzer
Copy link
Contributor Author

adatzer commented Oct 26, 2022

This has been included in #22 and resolved in latest v0.5.0. Closing.

@adatzer adatzer closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant