Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests using Micro for payload validation #736

Closed
matus-tomlein opened this issue Dec 2, 2022 · 0 comments
Closed

Add tests using Micro for payload validation #736

matus-tomlein opened this issue Dec 2, 2022 · 0 comments
Assignees
@matus-tomlein
Labels
type:admin About code or repo management.
Milestone
5.0.0

Comments

@matus-tomlein
Copy link
Contributor

Instead of validating event payloads using the ObjC Iglu Client, we could make use of Snowplow Micro. The Iglu Client is no longer maintained and not compatible with Swift Package Manager which makes it difficult to use as we move from Carthage to SPM. Instead, Micro is actively maintained and a common approach that we use in tests in other trackers as well.
@matus-tomlein matus-tomlein self-assigned this Dec 2, 2022
@matus-tomlein matus-tomlein added the type:admin About code or repo management. label Dec 2, 2022
@matus-tomlein matus-tomlein added this to the 5.0.0 milestone Dec 2, 2022
@matus-tomlein matus-tomlein mentioned this issue Dec 2, 2022
Merged
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
3bea23d
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
aea245f
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
64d5e43
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
a598a35
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
ae8dda3
matus-tomlein added a commit that referenced this issue Dec 5, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
f8365ac
@matus-tomlein matus-tomlein mentioned this issue Dec 5, 2022
Merged
matus-tomlein added a commit that referenced this issue Dec 7, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
2bcd1fd 
Clean up Mocker

Remove slather file
matus-tomlein added a commit that referenced this issue Dec 7, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
0453653 
PR #738
matus-tomlein added a commit that referenced this issue Dec 7, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
792bf67 
PR #738
matus-tomlein added a commit that referenced this issue Dec 7, 2022
@matus-tomlein
Add tests using Micro for payload validation (close #736)
d0ebda8 
PR #738
@matus-tomlein matus-tomlein mentioned this issue Dec 20, 2022
Merged
@matus-tomlein matus-tomlein mentioned this issue Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matus-tomlein matus-tomlein

Labels
type:admin About code or repo management.
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@matus-tomlein