Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation of enrichments JSON to Scala Common Enrich #807

Closed
alexanderdean opened this issue Jun 3, 2014 · 4 comments
Closed

Add validation of enrichments JSON to Scala Common Enrich #807

alexanderdean opened this issue Jun 3, 2014 · 4 comments
Assignees
@fblundun
Labels
3. Enrich
Milestone
Version 0.9.6

Comments

@alexanderdean
Copy link
Member

No description provided.

@alexanderdean alexanderdean added this to the JSON-powered enrichments milestone Jun 3, 2014
@alexanderdean
Copy link
Member Author

Adding validation to the calling code (EmrEtlRunner, Kinesis flow) is nice-to-have but if we validate in Scala Common Enrich we get both for free.

@alexanderdean alexanderdean changed the title Add validation of enrichments JSON to EmrEtlRunner Add validation of enrichments JSON to Scala Common Enrich Jun 3, 2014
@alexanderdean
Copy link
Member Author

If any enrichment fails validation, then we should throw a FatalEtlError.

@alexanderdean
Copy link
Member Author

Good news Fred - there is now some prior art here:

https://github.com/snowplow/snowplow/blob/feature/shredder/3-enrich/scala-hadoop-shred/src/main/scala/com.snowplowanalytics.snowplow.enrich/hadoop/ShredJobConfig.scala#L76

@alexanderdean
Copy link
Member Author

Fixed in 0.9.6, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fblundun fblundun

Labels
3. Enrich
Projects
None yet
Milestone
Version 0.9.6
Development

No branches or pull requests
2 participants
@alexanderdean @fblundun