Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Stream Collector: reduce logging #10

Open
BenFradet opened this issue Oct 22, 2018 · 0 comments
Open

Scala Stream Collector: reduce logging #10

BenFradet opened this issue Oct 22, 2018 · 0 comments
Assignees

Comments

@BenFradet
Copy link
Contributor

Placeholder for now but logging for every failed record seems too fine-grained

https://github.com/snowplow/snowplow/blob/08d2f51b44148169427e5f423f7ea4dd489af9e5/2-collectors/scala-stream-collector/kinesis/src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/sinks/KinesisSink.scala#L244

We could group errors by failures.

Review the whole logging story anyway

@BenFradet BenFradet self-assigned this Oct 22, 2018
@lukeindykiewicz lukeindykiewicz transferred this issue from snowplow/snowplow Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant