Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid preprocessing directive #124

Closed
elisehuard opened this issue Nov 14, 2013 · 5 comments
Closed

invalid preprocessing directive #124

elisehuard opened this issue Nov 14, 2013 · 5 comments

Comments

@elisehuard
Copy link

Unfortunate mixing of multiline comments and hash symbols gives this when compiling:

Data/Conduit/Internal.hs:607:4:
     error: invalid preprocessing directive
       #-}
      ^

Data/Conduit/Internal.hs:340:4:
     error: invalid preprocessing directive
      #-}
       ^

for conduit 1.0.9
Glasgow Haskell Compiler, Version 7.6.3, stage 2 booted by GHC version 7.4.2
on mac os x Maverick (10.9)

@elisehuard
Copy link
Author

Sorry, not comments, some sort of inlining (still learning).
Actually, putting the #-} at the end of line instead of next line fixes it.

@snoyberg
Copy link
Owner

Thanks for the report, the new CPP in Maverick has caused me breakage in a few other places too.

Would it be possible to send a pull request for this change, since I'm not able to test any of the changes on my system?

@jwiegley
Copy link
Contributor

I don't think the fix should be made in conduit, as there are many, many other packages that still fail due to problems like this. They are working on a GHC 7.6.4 patch that should fix this everywhere; meanwhile, you can install GCC yourself and change the settings file to use that GCC as your preprocessor instead of /usr/bin/gcc (which is actually Clang now) and that will fix the bug too. Fixing this in conduit is a tiny bandaid on a systemic problem.

@elisehuard
Copy link
Author

That is a fair point.

@elisehuard
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants