Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquire expose the ReleaseException exception #460

Closed
parsonsmatt opened this issue Mar 15, 2021 · 1 comment · Fixed by #498
Closed

Acquire expose the ReleaseException exception #460

parsonsmatt opened this issue Mar 15, 2021 · 1 comment · Fixed by #498

Comments

@parsonsmatt
Copy link
Contributor

I'm debugging a issue in persistent and it'd be nice to be able to see the exception provided to ReleaseException.
@parsonsmatt
Copy link
Contributor Author

Well, shoot. Adding a SomeException field on ReleaseException breaks all the instances that are derived.

@parsonsmatt parsonsmatt mentioned this issue Mar 16, 2021
Closed
shlevy added a commit to shlevy/conduit that referenced this issue Oct 6, 2022
@shlevy @parsonsmatt
Include the exception in ReleaseTypes indicating exceptional exit.
d067fd5 
Supercedes and resolves snoyberg#461.

Fixes snoyberg#460.

Co-authored-by: Shea Levy <shea@shealevy.com>
Co-authored-by: parsonsmatt <parsonsmatt@gmail.com>
@shlevy shlevy mentioned this issue Oct 6, 2022
Merged
shlevy added a commit to shlevy/conduit that referenced this issue Oct 6, 2022
@shlevy @parsonsmatt
Include the exception in ReleaseTypes indicating exceptional exit.
a96d12f 
Supercedes and resolves snoyberg#461.

Fixes snoyberg#460.

Co-authored-by: Shea Levy <shea@shealevy.com>
Co-authored-by: parsonsmatt <parsonsmatt@gmail.com>
shlevy added a commit to shlevy/conduit that referenced this issue Oct 7, 2022
@shlevy @parsonsmatt
Include the exception in ReleaseTypes indicating exceptional exit.
eb227a5 
Supercedes and resolves snoyberg#461.

Fixes snoyberg#460.

Co-authored-by: Shea Levy <shea@shealevy.com>
Co-authored-by: parsonsmatt <parsonsmatt@gmail.com>
shlevy added a commit to shlevy/conduit that referenced this issue Oct 7, 2022
@shlevy @parsonsmatt
Include the exception in ReleaseTypes indicating exceptional exit.
24e4af5 
Supercedes and resolves snoyberg#461.

Fixes snoyberg#460.

Co-authored-by: Shea Levy <shea@shealevy.com>
Co-authored-by: parsonsmatt <parsonsmatt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@parsonsmatt