Check for connection status in finalizer #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdepillabout Could you please check that it fixes the issue for you. |
| @@ -93,7 +93,13 @@ makeConnection r w c = do | |||
| -- already closed connection. | |||
| closedVar <- newIORef False | |||
|
|
|||
| _ <- mkWeakIORef istack c | |||
| let close = do | |||
| closed <- readIORef closedVar | |||
There was a problem hiding this comment.
I'm not certain it's necessary, but to avoid a potential race condition, what about using atomicModifyIORef to read the closed state and immediately write back True?
There was a problem hiding this comment.
I realize that's a change to how the code works now.
Kill read thread on exit from a server. Otherwise it reads from already closed socket, making harder to debugging similar issues in the library itself. Ignore IO errors in write and read thread. They pollute the output without good reason.
Yuras
force-pushed
the
n225
branch
2 times, most recently
from
6de70b9
to
2046a52
Compare
|
I'm not going to be able to test this until Tuesday. But the fix looks pretty close to what I described in #225, which did work for me, so I'd bet that this fix is good 👍 |
|
Travis failure on GHC 7.4.2 |
Connection could be closed via explicit `connectionClose` call or via finalizer attached to it. Both should check status to prevent writing to or reading from closed connection. See snoyberg#225
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fix for #225
It also contains related patch to cleanup test suit, please let me know if you want me to send it separately.