-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does keter override yesod's approot? #145
Comments
I remember I had to do something inside the app itself, but I managed to make it work. |
In the standard
|
Let me understand it better: To do it with keter we would need to extend it... but if anyone knows better please correct me :) |
keter is running on
|
meanwhile, I found this https://github.com/snoyberg/keter/blob/master/Keter/App.hs#L297
and I conclude that keter sets APPROOT to |
I am not an expert here :), but to add dispatch on path, we would need to add additional proxy level, and have 2 level (host, path) dispatching. |
would be fine, I have only one app. I do not want to dispatch on path (my apache is doing this?) I just want to pass the correct value of APPROOT to my application. As a work-around, is there a way to set APPROOT in some other place? source code says
so if I could put APPROOT in one of these, then it should be good? But how can I? I have no idea what these examples mean (in https://github.com/snoyberg/keter/blob/master/incoming/foo1_0/config/keter.yaml#L14 )
Ah! I put this in my application's
|
I doubt we can :), as it will generate more bugs. But we can think how to allow dispatching on path, most likely it should be possible, if we just improve the routing. Most likely do lookup based on host and path. Then we need to know if we want to rewrite(remove) path or forward it to the app. The problem I see is how to efficiently analyse path only for hosts which are configured with path. |
Sorry, I was re-editing my comment while you were answering. I seem to have a work-around now. Thanks for your time. Feel free to keep this issue open, or close. |
as a side note you can override the APPROOT in your Foundation.hs (https://github.com/yesodweb/yesod/wiki/Overriding-approot) |
I cannot get the following to work:
What do I put as
approot
in the application's config/settings.yml ? I thought it should be https://foo.bar/app/ (the externally visible name) but this does not work (the application does not produce the "/app" prefix).When I start the app directly (without keter) the behaviour is as expected. So keter must have some effect on the application. Where is that documented?
The text was updated successfully, but these errors were encountered: