New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Housekeeping Tasks #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why the build is failing and I'm having trouble recreating failure locally:
|
Something like that works better
bump to start travis
make 7.4 work
Update .travis.yml
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some features preparing the deb packages and, I've done some minor housekeeping tasks:
All of the tests under
tests/
seemed to be for a much older version of Keter. If these are still valid tests I will be happy to put them back. My goal is to implement some new tests where possible and these were a bit confusing for me as I started by trying to run thembundles/
toincoming/
I can't actually get the bundles tests working. I'm still looking into making it work with the current set of tests.
Worth noting that the documentation states that quoting wildcards "app.*.domain.net" is necessary and the bundles don't quote their host names.