Updates #30
Merged
Updates #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lower bound: we need condBenchmarks - upper bound: 1.25 will make e.g. `PackageName` opaque
Use the Cabal own parser, to cope with upcoming cabal-install config
format
repository hackage.haskell.org
url: http://hackage.haskell.org/
-- ...
Also add revision fields, though they are unused (see comments in code).
snoyberg
reviewed
Oct 18, 2016
| @@ -108,7 +101,8 @@ addPackage m entry = | |||
| case Map.lookup package' m of | |||
| Nothing -> go package' version | |||
| Just PackInfo { piVersion = oldv } -> | |||
| if version > oldv | |||
| -- in 01-index.tar there are entries with some version | |||
| maxVersion :: PackInfo -> PackInfo -> PackInfo | ||
| maxVersion pi1 pi2 = if piVersion pi1 <= piVersion pi2 then pi2 else pi1 |
There was a problem hiding this comment.
Given that we're not actually doing the comparison on piRevision, is there any purpose to this change?
|
Forcepushed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.