Add functions to ignore subtrees & result-streaming (yield) parsers - cont. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is a feature I've wanted for a while. Some of the naming was a little confusing to me at first ( |
|
LGTM. @ulikoehler mind giving a thumbs up before I merge? |
|
Definitively a thumbs up from me ;-) Thank you very much @pavelkogan for finally finishing this feature. I'm very glad to see this included in xml-conduit. @creichert I fully agree. I started to work on this about a year ago but I never got around to finishing it du to too heavy workload from university and job. I'll close the old PR. |
snoyberg
added a commit
that referenced
this pull request
Jul 17, 2015
Add functions to ignore subtrees & result-streaming (yield) parsers - cont.
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #40