Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to ignore subtrees & result-streaming (yield) parsers - cont. #58

Merged
merged 20 commits into from Jul 17, 2015

Conversation

Projects
None yet
4 participants
@pavelkogan
Copy link
Contributor

pavelkogan commented Jul 16, 2015

Continuation of #40

@creichert

This comment has been minimized.

Copy link

creichert commented Jul 16, 2015

Nice, this is a feature I've wanted for a while.

Some of the naming was a little confusing to me at first (tagIngore* and ignoreTag* variants) but overall the changes look pretty good. I don't see any immediate issues in the implementation. +1

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Jul 16, 2015

LGTM. @ulikoehler mind giving a thumbs up before I merge?

@ulikoehler

This comment has been minimized.

Copy link
Contributor

ulikoehler commented Jul 16, 2015

Definitively a thumbs up from me ;-)

Thank you very much @pavelkogan for finally finishing this feature. I'm very glad to see this included in xml-conduit.

@creichert I fully agree. I started to work on this about a year ago but I never got around to finishing it du to too heavy workload from university and job.

I'll close the old PR.

snoyberg added a commit that referenced this pull request Jul 17, 2015

Merge pull request #58 from pavelkogan/ignoretree
Add functions to ignore subtrees & result-streaming (yield) parsers - cont.

@snoyberg snoyberg merged commit b2c55d7 into snoyberg:master Jul 17, 2015

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Jul 17, 2015

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.