Change absolute paths to relative for index #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the index tar that is made is tarred with the absolute filepaths of all the .cabal files that go into the tar. While this works find on Unix-y machines, for some reason this introduces problems on Windows where the absolute path turns into "C: \Users\..." (with an extra space there), which makes yackage unusable on Windows. By changing the paths of the .cabal files to be relative, we nicely sidestep this problem.
|
Can you describe the problem you were seeing on Windows? |
|
Although |
Was lazy and only removed the path in one place the first time around. Removing the path from what gets passed into the tar means that some of the functions in the where clause no longer need to have a path argument and so those have been removed.
snoyberg
added a commit
that referenced
this pull request
Mar 4, 2015
Change absolute paths to relative for index
|
Cool, thanks for the patch! |
|
Thanks for Yackage (and all the other stuff in the Haskell ecosystem)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the index tar that is made is tarred with the absolute
filepaths of all the .cabal files that go into the tar. While this works
fine on Unix-y machines, for some reason this introduces problems on
Windows where the absolute path turns into "C: \Users..." (with an
extra space there), which makes yackage unusable on Windows. By changing
the paths of the .cabal files to be relative, we nicely sidestep this
problem.