Quote empty strings #24

snoyberg · Mar 4, 2013 · 67fc536 · 67fc536
1 parent 1e39943
commit 67fc536
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/Data/Yaml.hs b/Data/Yaml.hs
@@ -114,6 +114,11 @@ objToEvents' (Array list) rest =
 objToEvents' (Object pairs) rest =
     EventMappingStart Nothing
   : foldr ($) (EventMappingEnd : rest) (map pairToEvents $ M.toList pairs)
+
+-- Empty strings need special handling to ensure they get quoted. This avoids:
+-- https://github.com/snoyberg/yaml/issues/24
+objToEvents' (String "") rest = EventScalar "" StrTag SingleQuoted Nothing : rest
+
 objToEvents' (String s) rest = EventScalar (encodeUtf8 s) StrTag PlainNoTag Nothing : rest
 objToEvents' Null rest = EventScalar "null" NullTag PlainNoTag Nothing : rest
 objToEvents' (Bool True) rest = EventScalar "true" BoolTag PlainNoTag Nothing : rest

diff --git a/test/main.hs b/test/main.hs
@@ -241,7 +241,9 @@ sample = array
     [ D.String "foo"
     , object
         [ ("bar1", D.String "bar2")
+        , ("bar3", D.String "")
         ]
+    , D.String ""
     ]
 
 caseEncodeDecodeData :: Assertion