-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trouble with non-ASCII filenames on Windows #90
Comments
Also checked the diff, yaml/0.8.17.1...yaml/0.8.18.1, nothing relevant; and retested with runhaskell after adding |
Good catch. Do you want to take a stab at a PR to resolve? On Sun, Aug 14, 2016 at 6:11 PM, Paolo G. Giarrusso <
|
Working on snoyberg#90. Unfinished. Idea: reuse low-level API from GHC internals, since it has already tested low-level code to deal with non-ASCII filenames on different platforms. Current status: - Only for reading files. - This still passes tests on OS X. To test on Windows.
Working on snoyberg#90. Unfinished. Idea: reuse low-level API from GHC internals, since it has already tested low-level code to deal with non-ASCII filenames on different platforms. Current status: - Only for reading files. - This still passes tests on OS X (on lts-6.0). To test on Windows.
OK. I'm taking a look at (ab)using GHC's internals for this— |
Heh, indeed On Sun, Aug 14, 2016, 8:32 PM Paolo G. Giarrusso notifications@github.com
|
I just minimized commercialhaskell/stack#2491 to a bug in the Yaml library. Quoting myself there:
René/foo.yaml
testYaml.hs
:(That stack runhaskell is inside a project with
yaml
installed, in particular stack master on lts-6.0, hence it uses https://www.stackage.org/lts-6.0/package/yaml-0.8.17.1; the changelog at https://hackage.haskell.org/package/yaml-0.8.18.1/changelog does not mention this issue, nor does this issue tracker).What I've shown is on a fresh Win10 VM, inside
Git Bash
coming from Git for Windows.Already minimized to a bug in the Yaml library.
Analysys
I expect we end up here:
yaml/Text/Libyaml.hs
Lines 525 to 533 in f88b1bf
That uses
withCString
andfopen
, andwithCString
is documented here as "using a locale-dependent encoding".https://www.stackage.org/haddock/lts-6.0/base-4.8.2.0/Foreign-C-String.html
Also note: the source code is UTF8, and that's required to have it accepted by stack runhaskell, whether I use codepage 437 (the default) or 65001.
The text was updated successfully, but these errors were encountered: