Update CPP MIN_VERSION_* checks #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes should affect neither the interface nor the behaviour of this library. dee4776 introduced compatibility with conduit 1.0, while retaining compatibility with pre-1.0 conduit. Because yaml has required conduit 1.0+ since 932a36a, these version checks are no longer necessary. aa154a5 introduced compatibility with conduit 1.1, while retaining compatibility with pre-1.1 conduit. Because yaml has required conduit 1.1+ since fe4ef27, these version checks are no longer necessary.
aeson 1.0.0.0 deprecates Data.Aeson.Encode. This change changes the relevant import statement to import from Data.Aeson.Text, while retaining compatibility with pre-1.0.0 aeson through CPP.
|
The Travis-CI failures are lies, of course. |
snoyberg
approved these changes
Jun 16, 2017
|
Thanks! |
snoyberg
added a commit
that referenced
this pull request
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove
MIN_VERSION_conduit()checks that will always be true, in order to remove clutter, and addMIN_VERSION_aeson()checks, in order to resolve deprecation warnings (and prevent unpleasant surprises with future aeson versions).These changes should affect neither the interface nor the behaviour of this library.