-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty, resolve #65 #66
Conversation
| otherwise = EventScalar (encodeUtf8 s) StrTag PlainNoTag Nothing | ||
|
||
-- | Strings which must be escaped so as not to be treated as non-string scalars. | ||
specialStrings :: HashSet.HashSet Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these two function just be imported from .Internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
Overall looks very nice, I just had a few comments. |
ping @snoyberg, fixed the issues. |
Thanks! |
Thanks for making new release. Works like a charm: phadej/travis-meta-yaml@0995cb8 |
No description provided.