Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation option to display portraits inline / onstage #552

Open
chrisgregan opened this issue Oct 24, 2016 · 4 comments
Open

Conversation option to display portraits inline / onstage #552

chrisgregan opened this issue Oct 24, 2016 · 4 comments
Labels
enhancement Adds a new feature.

Comments

@chrisgregan
Copy link
Contributor

Add two new keywords to the conversation system.
inline: Display portraits for the speaking character inline on the Say Dialog
onstage: Display portraits for the speaking character on the Stage

The default state is onstage. These keywords should not be used together, but if they are then onstage takes priority. The character keeps track of where to display portraits for subsequent dialog lines.

Requested on the forum

@chrisgregan chrisgregan added enhancement Adds a new feature. Narrative labels Oct 24, 2016
@lealeelu
Copy link
Contributor

I'll take a crack at this.

@andyandy2015
Copy link

Hello,
Is this working? Thanks

@lealeelu
Copy link
Contributor

I was pretty much on top of the solution here: #566
but thought of a better way to do it later on that would fit better with the current code base. Feel free to cherrypick those commits in and give it a try. I don't know when I'll get back to working on it.

@imcvampire
Copy link

Hi all,

Any update on this issue?

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants