Trying to add support for private spot feeds and also multicast CoT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Usage section to include optional -p PASSWORD for those Spot XML feeds that were created private with a password.
Added a very low level check if the address used is multicast (this check should be done with re), so that multicast packets are used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for spot private feeds by means of using changes proposed in https://github.com/jmarcorb/spot-sdk instead the fantastic but maybe abandoned parent project by gregology.
Also added support for multicast addresses for sending CoT messages.
As you will see I am not an expert python coder, but I tried to do my best with the little time I had available. I hope it helps.
I have done a few tests and these changes seem to work properly.