Replaces 'symbol' with 'asset' and 'currency' in Events for consistency #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes issue #52 |
Since symbol differs by Exchange, we decompose this into asset and currency so that these are consistent across Exchanges.
barrysteyn
reviewed
Nov 24, 2017
| return subscriptions | ||
|
|
||
| def _subscribe(self, asset, currency, channel, exchange=None, | ||
| interval=1.0): | ||
| if self._websocket_client_class is not None: |
There was a problem hiding this comment.
In the implementation below, if WS client is defined, it will ignore the Rest client class, implying that if you have both WS client and Rest Client defined, and (for argument sake) the subscribe you are interested in is defined on the Rest client, it will get ignored here?
There was a problem hiding this comment.
I agree with you. We would need to define a mechanism to resolve that. I'll create an issue for that. This has existed in the codebase for a while and doesn't need to be fixed in this PR.
barrysteyn
reviewed
Nov 24, 2017
|
|
||
| def subscribe(self, asset, currency, channel, interval=1.0, exchange=None): | ||
| exchange = exchange if exchange else self.exchange | ||
| # FIXME: Remove channel_info or make it more generic |
There was a problem hiding this comment.
Try to make it more generic...
This was referenced Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symbol differs by Exchange, we decompose this into asset and currency so
that these are consistent across Exchanges.