New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set comprehension in get_events #66

Merged

snudler6 merged 2 commits into snudler6:master from cool-RR:patch-1

Jul 30, 2020

Contributor

cool-RR commented Jul 28, 2020

Haven't tested this. Can we count on the tests to cover it?


          Use set comprehension in get_events

1b71b49

Owner

snudler6 commented Jul 30, 2020

Haven't tested this. Can we count on the tests to cover it?

Pretty sure tests will cover it.
The CI did catch a small PEP8 mismatch. Can you fix it, and I'll merge the change :)

src/time_travel/event_pool.py:48:62: W291 trailing whitespace


          Update event_pool.py

8acd50b

snudler6 approved these changes

View reviewed changes

snudler6 merged commit cf1d71b into snudler6:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment