Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Changed to verbose assertions #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reallymello
Copy link

Before my changes it was leaving me a bit uneasy on the passes not knowing what rules were actually checked and how many elements were scanned. I changed the output so each rule is a test case.

√ Passed [ok]: aXe rule: aria-allowed-attr (2 elements checked)
√ Passed [ok]: aXe rule: aria-hidden-body (1 elements checked)
√ Passed [ok]: aXe rule: aria-required-attr (2 elements checked)
√ Passed [ok]: aXe rule: aria-required-children (2 elements checked)
√ Passed [ok]: aXe rule: aria-required-parent (2 elements checked)

On the failing case side it was originally stopping execution on the first failure so downstream checks were not run or reported which would make remediating violations frustrating tackling them one at a time. I now report a test case failure for each rule and control.

× Failed [fail]: (aXe rule: color-contrast - Elements must have sufficient color contrast
In element: #vap-plan > a > h3)
In element: #vap-plan > a > h3
at processTicksAndRejections (internal/process/task_queues.js:93:5)

× Failed [fail]: (aXe rule: color-contrast - Elements must have sufficient color contrast
In element: #vap-plan > p:nth-child(3))
In element: #vap-plan > p:nth-child(3)
at processTicksAndRejections (internal/process/task_queues.js:93:5)

× Failed [fail]: (aXe rule: color-contrast - Elements must have sufficient color contrast
In element: #vap-book > a > h3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant