Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failures for ruby-head #5

Merged
merged 1 commit into from
Jun 25, 2013
Merged

Allow failures for ruby-head #5

merged 1 commit into from
Jun 25, 2013

Conversation

mbj
Copy link
Collaborator

@mbj mbj commented Jun 25, 2013

Travis with rub-head is broken. We should allow failures here.

@snusnu Pls add me as collab!

snusnu added a commit that referenced this pull request Jun 25, 2013
Allow failures for ruby-head
@snusnu snusnu merged commit 15192c1 into snusnu:master Jun 25, 2013
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e78b8c3 on mbj:master into 6e181b1 on snusnu:master.

@snusnu
Copy link
Owner

snusnu commented Jun 25, 2013

@mbj thx! also, i added you as a collaborator

@dkubb
Copy link

dkubb commented Jun 25, 2013

@snusnu Id probably recommend disabling @coveralls commenting. I haven't found it adds much value. Maybe if it were possible to configure it to notify only when coverage drops.

I only like being notified by systems when something exceptional and unexpected occurs. Coverage staying the same or increasing is expected and a natural occurrence in a healthy codebase, so I don't see any need to be notified.

It's the same reason I configure travis like this:

notifications:
  irc:
    channels:
      - irc.freenode.org#rom-rb
    on_success: never
    on_failure: change
  email:
    recipients:
      - dan.kubb@gmail.com
    on_success: never
    on_failure: change

Which will not send me any notifications except the first time the build breaks.

@snusnu
Copy link
Owner

snusnu commented Jun 25, 2013

@dkubb good call! i already wanted to do that cause yeah, imo the coveralls comments are noise, and substation is already 100% mutation covered anyway, so we'll notice a drop in coverage anyway as rake ci will fail on travis.

all that said, i just disabled coveralls commenting for this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants