This repository has been archived by the owner on May 29, 2018. It is now read-only.
Add GTK-3.22 theme #414
Open
Add GTK-3.22 theme #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a solution for the remaining messages.
Still unsure about the linear-gradient thing. If transpararent was the right value. I saw other implementations, where the first color stop value is used for the second one. |
Based upon the 3.20 theme. It was only adjusted in those parts, where GTK-3.22 complained.
Mainly:
Theme parsing error: gtk.css:6363:24: Using Pango syntax for the font: style property is deprecated; please use CSS syntax
--> Font: Changing font to font-family
Theme parsing error: gtk.css:453:56: Using one color stop with linear-gradient() is deprecated.
--> linear-gradient(): Adding 'transparent' where the second color stop argument were missing (_entries.scss 124,128; _scales.scss: 368; _drawing.scss: 71, 77, 83, 89, 98, 107, 116, 304, 377, 392, 406, 418, 433, 456; _header-bars: 68)
Theme parsing error: gtk.css:6936:10: Not using units is deprecated.Assuming 'px'.
--> px added
Theme parsing error: gtk.css:5446:11: Expected a string.
--> Changing font to font-size
Theme parsing error: gtk.css:5673:16: not a number
--> Changing font to font-weight
Closes #409
|
@snwh have you had a chance to review this? |
|
@snwh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon the 3.20 theme. It was only adjusted in those parts, where GTK-3.22 complained.
Mainly:
Theme parsing error: gtk.css:6363:24: Using Pango syntax for the font: style property is deprecated; please use CSS syntax
--> Font: Changing font to font-family
Theme parsing error: gtk.css:453:56: Using one color stop with linear-gradient() is deprecated.
--> linear-gradient(): Adding 'transparent' where the second color stop argument were missing (_entries.scss 124,128; _scales.scss: 368; _drawing.scss: 71, 77, 83, 89, 98, 107, 116, 304, 377, 392, 406, 418, 433, 456; _header-bars: 68)
Theme parsing error: gtk.css:6936:10: Not using units is deprecated.Assuming 'px'.
--> px added
Remaing issues:
Regarding specified fonts like "font: 18px;""
Closes #409
Again. Dunno if it's really OK what I have done. I did not notice any drawbacks using the modified theme.
Remaining stuff ware the warning messages regarding "Expected a string" and "not a number". Didn't find information on it. So not sure if changing it to font-family will help, or specifing a dummy font in those cases.