Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Border outline for smaller icons #3

Closed
PJ-Singh-001 opened this issue Oct 15, 2017 · 1 comment
Closed

Border outline for smaller icons #3

PJ-Singh-001 opened this issue Oct 15, 2017 · 1 comment

Comments

@PJ-Singh-001
Copy link

GREAT JOB! And Thank You. :)

Here is a suggestion...

The border on some of the smaller icons looks out of place...

As an example, the outline for the application-pdf.svg is a grey color. Maybe the outline should be a darker shade of the most prominent color in the icon. In the case of application-pdf.svg, perhaps a dark red color?

Still you have to be careful not to use too dark a color. For example, I think the folders.svg is on the right track, but the darker orange outline, of four the smaller sizes, may be a bit too dark, IMHO.

Is it possible to make the smaller icons exactly like the largest icon, and not put a border? (Not sure if that will maintain enough contrast at the smaller sizes, but may be worth a try?)

@snwh
Copy link
Owner

snwh commented Oct 21, 2017

Thanks, I have considered these things already. There's reasons for the colour choices for the borders/outlines – using black allows for the border to disappear when the icons are over a dark background:

screenshot from 2017-10-21 13-29-13

Note the subtle difference in the PDF and the archive icon (which has a yellow border).

Mind you, I haven't completely decided whether to go with coloured or black (this theme is still in-development so things are subject to change.)

@snwh snwh closed this as completed Oct 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants