Skip to content

Commit

Permalink
Air-8 : Fix for over-sized context header block.
Browse files Browse the repository at this point in the history
  • Loading branch information
bozimmerman committed Jun 6, 2023
1 parent 089ad0e commit d16413a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/processor/minidump.cc
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,11 @@ bool MinidumpContext::Read(uint32_t expected_size) {
// when only one of them will be used.
switch (cpu_type) {
case MD_CONTEXT_X86: {
if (expected_size != sizeof(MDRawContextX86)) {
//BZ: There is some sort of extended x86 context structure that is unknown
// to breakpad, but apparantly, it is 2739 bytes long. Mapping the smaller
// structure on top seems to be fine, and fixes the issue with refusing to
// process a stack trace w/o a valid context. (AIR-8)
if (expected_size < sizeof(MDRawContextX86)) {
BPLOG(ERROR) << "MinidumpContext x86 size mismatch, " <<
expected_size << " != " << sizeof(MDRawContextX86);
return false;
Expand Down

0 comments on commit d16413a

Please sign in to comment.