-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RfC]: Add Support for Multiple Snyk Organizations #167
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
For clarity since there might be multiple orgs, I think it'd be useful to add in the tab metadata the org slug+ID. Simply adding in SnykTab.tsx the following
What do you think? |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
1 similar comment
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Silthus on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Alright @Silthus, can you rebase off develop ? thanks |
Ok I rebased. |
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What this does
One big feature that is currently missing from the plugin is the support for multiple Snyk organizations. This PR adds that feature in a backwards compatible and minimal way.
It adds a new
snyk.io/org-ids
annotations that allows defining a comma separated list of organization ids. It will then iterate over those organizations and tries to find any of the specified targets or projects within any of those organizations, aggregating them into a single list.In addition the link to the individual tabs changes when multiple orgs are specified to include the org slug in the url. This avoids duplicate links.
Notes for the reviewer
I also upgraded all dependencies to the latest backstage version, as I was unable to build the project otherwise. The commits are cleanly separated.
Don't hesitate to reach out if you have any additional requests or things your would like to change.
More information
This PR is supported by the Interhyp as part of the ING.