Migrate tests to Jest #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're in the process of moving the Broker to TypeScript so that we can improve our confidence when upgrading dependencies and making other changes. However, the legacy testing frameworks and tools were making progress slow. Given the tests need to also roll forward, we've opted to migrate these first. In general, the tests should be mostly identical, but instead of using `proxyquire`, `tap`, `sinon` and `require-reload` we only use Jest. The aim is not to make the tests "better" yet, only to focus on modernising the infrastructure without any changes to the source code. This should make the test migrations easier to read and review. - Delete the object assign test. I trust Node not to break Object.assign() - Re-enabled the proxying-decision test. This had a bad file extension, so it probably wasn't picked up by Tap for the past 3 years
ohad2712
force-pushed
the
chore/convert-tests-to-jest
branch
from
7c60837
to
b3322ba
Compare
carlos-snyk
approved these changes
Jul 20, 2020
|
🎉 This PR is included in version 4.86.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're in the process of moving the Broker to TypeScript so that we can improve our confidence when upgrading dependencies and making other changes. However, the legacy testing frameworks and tools were making progress slow. Given the tests need to also roll forward, we've opted to migrate these first. In general, the tests should be mostly identical, but instead of using
proxyquire,tap,sinonandrequire-reload,tap-only, we use Jest.The aim is not to make the tests "better" yet, only to focus on modernising the infrastructure without any changes to the source code. This should make the test migrations easier to read and review.