feat: single depGraph with subject #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds functionality to the sbom service, allowing users to pass in a single depGraph *and* a subject that will be honored. To achieve this, we simply send the multi-depgraph body with only one depGraph, and the subject with it. Additionally, I've switched from using raw strings to construct the body-JSON to using `json.RawMessage` and proper types / structs. This also means that I've had to make the `Name` and `Version` fields of the `subject` type public. And to make the subject's usage easier in external packages, I've made the `Subject` type itself public as well. `json.RawMessage` is nice because it can be used to tell Go that a certain field is already raw JSON, and has never been fully decoded into a custom type. As such, when marshaling JSON, that `RawMessage` is simply added to the rest of the document without any changes.
Closed
danielroymoore
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds functionality to the sbom service, allowing users to pass in a single depGraph and a subject that will be honored.
To achieve this, we simply send the multi-depgraph body with only one depGraph, and the subject with it.
Additionally, I've switched from using raw strings to construct the body-JSON to using
json.RawMessageand proper types / structs. This also means that I've had to make theNameandVersionfields of thesubjecttype public. And to make the subject's usage easier in external packages, I've made theSubjecttype itself public as well.json.RawMessageis nice because it can be used to tell Go that a certain field is already raw JSON, and has never been fully decoded into a custom type. As such, when marshaling JSON, thatRawMessageis simply added to the rest of the document without any changes.