Merge pull request #3056 from snyk/fix/target-branch

fix: remove target.branch
snyk · Mar 25, 2022 · 0064077 · 0064077
2 parents 643dba5 + 810b6b8
commit 0064077
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/lib/iac/envelope-formatters.ts b/src/lib/iac/envelope-formatters.ts
@@ -26,7 +26,7 @@ export function convertIacResultToScanResult(
     target:
       Object.keys(gitTarget).length === 0
         ? { name: iacResult.projectName }
-        : { ...gitTarget, branch: 'master' },
+        : { remoteUrl: gitTarget.remoteUrl },
     policy: policy?.toString() ?? '',
   };
 }
diff --git a/test/jest/acceptance/iac/cli-share-results.spec.ts b/test/jest/acceptance/iac/cli-share-results.spec.ts
@@ -82,7 +82,6 @@ describe('CLI Share Results', () => {
               policy: '',
               name: 'arm',
               target: {
-                branch: 'master',
                 remoteUrl: 'http://github.com/snyk/cli.git',
               },
             },

diff --git a/test/jest/unit/iac/cli-share-results.fixtures.ts b/test/jest/unit/iac/cli-share-results.fixtures.ts
@@ -121,7 +121,6 @@ export const expectedEnvelopeFormatterResults = [
     policy: '',
     target: {
       remoteUrl: 'http://github.com/snyk/cli.git',
-      branch: 'master',
     },
   },
   {
@@ -163,7 +162,6 @@ export const expectedEnvelopeFormatterResults = [
     policy: '',
     target: {
       remoteUrl: 'http://github.com/snyk/cli.git',
-      branch: 'master',
     },
   },
 ];

diff --git a/test/jest/unit/iac/cli-share-results.spec.ts b/test/jest/unit/iac/cli-share-results.spec.ts
@@ -40,6 +40,7 @@ describe('CLI Share Results', () => {
       firstCallResult,
       secondCallResult,
     ] = envelopeFormattersSpy.mock.results;
+
     expect(firstCallResult.value).toEqual(expectedEnvelopeFormatterResults[0]);
     expect(secondCallResult.value).toEqual(expectedEnvelopeFormatterResults[1]);
   });
@@ -57,6 +58,7 @@ describe('CLI Share Results', () => {
       firstCallResult,
       secondCallResult,
     ] = envelopeFormattersSpy.mock.results;
+
     expect(firstCallResult.value).toEqual(
       expectedEnvelopeFormatterResultsWithPolicy[0],
     );