fix: apps create command

* Update API version to 2022-03-11~experimental
* Update formatting out app create output
* Update field name for data fetched from the API
* Upate make request rest to handle 400 and greater than 400 errors separately
* Add no compression option to request payload

src/cli/commands/apps/create-app.ts

@@ -36,12 +36,13 @@ export async function createApp(
     url: getAppsURL(EAppsURL.CREATE_APP, { orgId }),
     body: {
       name,
-      redirectUris,
+      redirect_uris: redirectUris,
       scopes,
     },
     qs: {
-      version: '2021-08-11~experimental',
+      version: '2022-03-11~experimental',
     },
+    noCompression: true,
   };
 
   try {

src/lib/apps/rest-utils.ts

@@ -98,24 +98,27 @@ Meta:\t${meta}`;
 }
 
 export function handleCreateAppRes(res: ICreateAppResponse): string {
+  debug(res);
   const {
     name,
-    clientId,
-    redirectUris,
+    client_id,
+    redirect_uris,
     scopes,
-    isPublic,
-    clientSecret,
+    is_public,
+    client_secret,
+    access_token_ttl_seconds,
   } = res.data.attributes;
 
   return `Snyk App created successfully!
 Please ensure you save the following details:
 
-App Name:\t${name}
-Client ID:\t${clientId}
-Redirect URIs:\t${redirectUris}
-Scopes:\t${scopes}
-Is App Public:\t${isPublic}
+App Name: ${name}
+Client ID: ${client_id}
+Redirect URIs: ${redirect_uris}
+Scopes: ${scopes}
+Is App Public: ${is_public}
+Access token TTL seconds: ${access_token_ttl_seconds}
 Client Secret (${chalk.redBright(
     'keep it safe and protected',
-  )}):\t${clientSecret}`;
+  )}): ${client_secret}`;
 }

src/lib/apps/types.ts

@@ -14,11 +14,12 @@ export interface ICreateAppResponse {
     id: string;
     attributes: {
       name: string;
-      clientId: string;
-      redirectUris: string[];
+      client_id: string;
+      redirect_uris: string[];
       scopes: string[];
-      isPublic: boolean;
-      clientSecret: string;
+      is_public: boolean;
+      client_secret: string;
+      access_token_ttl_seconds: number;
     };
     links: {
       self: string;

src/lib/request/promise.ts

@@ -35,11 +35,15 @@ export async function makeRequestRest<T>(payload: any): Promise<T> {
       if (error) {
         return reject(error);
       }
-      if (res.statusCode >= 400) {
+      if (res.statusCode === 400) {
         return reject({
           code: res.statusCode,
           body: JSON.parse(body as any),
         });
+      } else if (res.statusCode >= 401) {
+        return reject({
+          code: res.statusCode,
+        });
       }
       resolve(JSON.parse(body as any) as T);
     });

src/lib/request/request.ts

@@ -30,7 +30,7 @@ function setupRequest(payload: Payload) {
 
   const versionNumber = getVersion();
   const body = payload.body;
-  let data;
+  let data = body;
 
   delete payload.body;
 
@@ -40,7 +40,10 @@ function setupRequest(payload: Payload) {
 
   payload.headers['x-snyk-cli-version'] = versionNumber;
 
-  if (body) {
+  const noCompression = payload.noCompression;
+
+  if (body && !noCompression) {
+    debug('compressing request body');
     const json = JSON.stringify(body);
     if (json.length < 1e4) {
       debug(JSON.stringify(body, null, 2));
@@ -134,6 +137,7 @@ export async function makeRequest(
   payload: Payload,
 ): Promise<{ res: needle.NeedleResponse; body: any }> {
   const { method, url, data, options } = setupRequest(payload);
+  debug(data);
 
   return new Promise((resolve, reject) => {
     needle.request(method, url, data, options, (err, res, respBody) => {

src/lib/request/types.ts

@@ -10,4 +10,5 @@ export interface Payload {
   json?: boolean;
   timeout?: number;
   family?: number;
+  noCompression?: boolean;
 }

test/acceptance/fake-server.ts

@@ -451,7 +451,7 @@ export const fakeServer = (basePath: string, snykToken: string): FakeServer => {
   app.post(`${basePath}/orgs/:orgId/apps`, (req, res) => {
     const { orgId } = req.params;
     const name = req.body.name;
-    const redirectUris = req.body.redirectUris;
+    const redirect_uris = req.body.redirect_uris;
     const scopes = req.body.scopes;
     res.send(
       JSON.stringify({
@@ -463,14 +463,15 @@ export const fakeServer = (basePath: string, snykToken: string): FakeServer => {
           id: '84144c1d-a491-4fe5-94d1-ba143ba71b6d',
           attributes: {
             name,
-            clientId: '9f26c6c6-e04b-4310-8ce4-c3a6289d0633',
-            redirectUris,
+            client_id: '9f26c6c6-e04b-4310-8ce4-c3a6289d0633',
+            redirect_uris,
             scopes,
-            isPublic: false,
-            clientSecret: 'super-secret-client-secret',
+            is_public: false,
+            client_secret: 'super-secret-client-secret',
+            access_token_ttl_seconds: 3600,
           },
           links: {
-            self: `/orgs/${orgId}/apps?version=2021-08-11~experimental`,
+            self: `/orgs/${orgId}/apps?version=2022-03-11~experimental`,
           },
         },
       }),