fix: PR feedback

snyk · Mar 12, 2024 · 9abc1df · 9abc1df
1 parent 5f2f266
commit 9abc1df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/lib/request/request.ts b/src/lib/request/request.ts
@@ -140,7 +140,6 @@ export async function makeRequest(
   payload: Payload,
 ): Promise<{ res: needle.NeedleResponse; body: any }> {
   const { method, url, data, options } = setupRequest(payload);
-  // debug(data);
 
   return new Promise((resolve, reject) => {
     needle.request(method, url, data, options, (err, res, respBody) => {

diff --git a/test/jest/acceptance/cli-json-output.spec.ts b/test/jest/acceptance/cli-json-output.spec.ts
@@ -89,20 +89,12 @@ describe('test --json', () => {
 
     const {
       code,
-      stdout,
       stdoutBuffer,
-      stderr,
-      stderrBuffer,
-    } = await runSnykCLI(`test -d --json`, {
+    } = await runSnykCLI(`test --json`, {
       cwd: project.path(),
-      env: { ...env, DEBUG: '*' },
+      env,
       bufferOutput: true,
     });
-    console.log('****', 'stderr ****\n', stderr, '\n');
-    console.log('****', 'stderrBuf ****\n', stderrBuffer, '\n');
-    console.log('****', 'stdout ****\n', stdout, '\n');
-    console.log('****', 'stdoutBuf ****\n', stdoutBuffer, '\n');
-    console.log('****', 'code ****\n', code, '\n');
 
     expect(code).toEqual(1);
     expect(stdoutBuffer).toBeDefined();

diff --git a/test/jest/util/runCommand.ts b/test/jest/util/runCommand.ts
@@ -1,6 +1,5 @@
 import { SpawnOptionsWithoutStdio } from 'child_process';
 import { spawn } from 'cross-spawn';
-// const debug = require('debug')('acceptance-test:runCommand');
 
 type RunCommandResult = {
   code: number;
@@ -10,6 +9,8 @@ type RunCommandResult = {
   stderrBuffer?: Buffer;
 };
 
+// bufferOutput sets the RunCommandResult stdoutBuffer and stderrBuffer
+// useful if the stdout or stderr string output is too large for the v8 engine
 type RunCommandOptions = SpawnOptionsWithoutStdio & { bufferOutput?: boolean };
 
 const runCommand = (