Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPv6 detection to fix auth bug #1116

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

dkontorovskyy
Copy link
Contributor

@dkontorovskyy dkontorovskyy commented May 12, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add support to clients who are using IPv6

Blocked until new release of needle
tomas/needle#316 (comment)

NOTA BENE: need to update needle version in this PR after it's release

@dkontorovskyy dkontorovskyy requested a review from a team as a code owner May 12, 2020 07:44
@dkontorovskyy dkontorovskyy self-assigned this May 12, 2020
@ghost ghost requested review from ekbsnyk and orsagie May 12, 2020 07:44
@dkontorovskyy dkontorovskyy changed the title feat: add IPv6 detection to fix auth bug [WIP] feat: add IPv6 detection to fix auth bug May 12, 2020
@dkontorovskyy dkontorovskyy force-pushed the feat/app-ipv6-suuport branch 4 times, most recently from f1f76b6 to 3a1561d Compare May 27, 2020 10:57
@dkontorovskyy dkontorovskyy changed the title [WIP] feat: add IPv6 detection to fix auth bug feat: add IPv6 detection to fix auth bug May 27, 2020
@dkontorovskyy dkontorovskyy changed the title feat: add IPv6 detection to fix auth bug [WIP] feat: add IPv6 detection to fix auth bug May 27, 2020
@dkontorovskyy dkontorovskyy changed the title [WIP] feat: add IPv6 detection to fix auth bug feat: add IPv6 detection to fix auth bug May 27, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2020

Expected release notes (by @dkontorovskyy)

features:
add IPv6 detection to fix auth bug (fae72ff)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

Copy link
Contributor

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkontorovskyy dkontorovskyy merged commit 9b71fc3 into master May 27, 2020
@dkontorovskyy dkontorovskyy deleted the feat/app-ipv6-suuport branch May 27, 2020 12:00
@snyksec
Copy link

snyksec commented May 27, 2020

🎉 This PR is included in version 1.330.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants