-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IPv6 detection to fix auth bug #1116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkontorovskyy
force-pushed
the
feat/app-ipv6-suuport
branch
from
May 12, 2020 07:45
3afd434
to
59699c2
Compare
dkontorovskyy
changed the title
feat: add IPv6 detection to fix auth bug
[WIP] feat: add IPv6 detection to fix auth bug
May 12, 2020
dkontorovskyy
force-pushed
the
feat/app-ipv6-suuport
branch
4 times, most recently
from
May 27, 2020 10:57
f1f76b6
to
3a1561d
Compare
dkontorovskyy
changed the title
[WIP] feat: add IPv6 detection to fix auth bug
feat: add IPv6 detection to fix auth bug
May 27, 2020
dkontorovskyy
changed the title
feat: add IPv6 detection to fix auth bug
[WIP] feat: add IPv6 detection to fix auth bug
May 27, 2020
dkontorovskyy
changed the title
[WIP] feat: add IPv6 detection to fix auth bug
feat: add IPv6 detection to fix auth bug
May 27, 2020
dkontorovskyy
force-pushed
the
feat/app-ipv6-suuport
branch
from
May 27, 2020 11:38
3a1561d
to
9b492a0
Compare
anthogez
reviewed
May 27, 2020
dkontorovskyy
force-pushed
the
feat/app-ipv6-suuport
branch
from
May 27, 2020 11:40
9b492a0
to
fae72ff
Compare
Expected release notes (by @dkontorovskyy) features:
|
aviadhahami
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anthogez
reviewed
May 27, 2020
anthogez
reviewed
May 27, 2020
gitphill
approved these changes
May 27, 2020
anthogez
approved these changes
May 27, 2020
🎉 This PR is included in version 1.330.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support to clients who are using IPv6
Blocked until new release of
needle
tomas/needle#316 (comment)
NOTA BENE: need to update needle version in this PR after it's release