Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Snyk Container help text #1189

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

garethr
Copy link
Contributor

@garethr garethr commented Jun 16, 2020

  • Fixed alignment of options
  • Added missing global options
  • Added examples, including for archive files
  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Improves the help text in the CLI for the snyk container commands.

How should this be manually tested?

snyk container --help

Any background context you want to provide?

The features around archives are already in the CLI, just not in the docs.

Additional questions

@garethr garethr requested a review from a team as a code owner June 16, 2020 16:35
@garethr garethr requested a review from a team June 16, 2020 16:38
Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@garethr garethr force-pushed the chore-improve-snyk-container-help branch 2 times, most recently from bda9230 to f2939b6 Compare June 17, 2020 05:54
@snyksec
Copy link

snyksec commented Jun 17, 2020

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 3757780

* Fixed alignment of options
* Added missing global options
* Added examples, including for archive files
@garethr garethr force-pushed the chore-improve-snyk-container-help branch from f2939b6 to 3757780 Compare June 19, 2020 08:34
@garethr garethr requested a review from a team as a code owner June 19, 2020 08:34
@ghost ghost requested review from aviadhahami and dkontorovskyy June 19, 2020 08:34
@garethr garethr merged commit bc7eead into master Jun 19, 2020
@garethr garethr deleted the chore-improve-snyk-container-help branch June 19, 2020 09:04
@snyksec
Copy link

snyksec commented Jun 19, 2020

🎉 This PR is included in version 1.346.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants