feat: detect other files & suggest to use --all-projects #1233
Conversation
ghost
requested review from
lili2311
force-pushed
the
feat/suggest-all-projects
branch
from
c643e26
to
049f1a3
Compare
lili2311
force-pushed
the
feat/suggest-all-projects
branch
from
049f1a3
to
bff4ace
Compare
| (advertiseAllProjectsCount && foundProjectCount | ||
| ? chalk.bold.white( | ||
| `Tip: Detected multiple supported manifests (${foundProjectCount}), ` + | ||
| 'use --all-projects --detection-depth=4 to scan all of them at once.\n\n', |
There was a problem hiding this comment.
--detection-depth=4 is this now the default?
There was a problem hiding this comment.
our default is 2 which basically finds not much, 4 seemed to find much more, also it looks more impactful rather than suggesting to scan for the sake of 1 more file. What are thoughts on looking deeper by default?
There was a problem hiding this comment.
yea think whatever we suggest (and use) here should be the default, if that's 4, lets make it default 4 too
| try { | ||
| const extraTargetFiles = await find(root, [], AUTO_DETECTABLE_FILES, 4); | ||
| const foundProjectsCount = | ||
| extraTargetFiles.length > 1 ? extraTargetFiles.length - 1 : undefined; |
There was a problem hiding this comment.
is it more interesting to use which files (their path and name) we found? rather than just a count?
There was a problem hiding this comment.
Interesting, how would you stop this list from getting too big? file-a, file-b and 24 more... or something?
There was a problem hiding this comment.
yea maybe truncate to a reasonable limit
There was a problem hiding this comment.
so changing both the message for gradle and this one? They both use the same ish wording & show how many more you could scan with an different option? This function handles both discovered gradle sub-proejcts (where we have the sub-project names) and now also extra manifests that you could scan with --all-projects
lili2311
force-pushed
the
feat/suggest-all-projects
branch
from
bff4ace
to
3ec9c70
Compare
lili2311
force-pushed
the
feat/suggest-all-projects
branch
from
3881e73
to
20b1811
Compare
|
🎉 This PR is included in version 1.358.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Suggest scanning with
--all-projectswhen we detect other supported manifests up to 4 sub-directories deep. For bothtestandmonitorto help discover the new feature.Screenshots
Updated
