Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct infrastructure as code error import #1293

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix: correct infrastructure as code error import #1293

merged 1 commit into from
Jul 28, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jul 28, 2020 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Import the correct error & add tests to ensure this is covered.

@lili2311 lili2311 requested review from a team as code owners July 28, 2020 10:00
@lili2311 lili2311 self-assigned this Jul 28, 2020
@ghost ghost requested a review from MegaBean July 28, 2020 10:00
@lili2311 lili2311 force-pushed the fix/import-correct-isac-error branch from 2bcc7be to 818aa76 Compare July 28, 2020 10:00
@lili2311 lili2311 force-pushed the fix/import-correct-isac-error branch from 818aa76 to efbcf84 Compare July 28, 2020 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2020 •
edited by lili2311

Expected release notes (by @lili2311)

fixes:
correct iac error import & add tests (efbcf84)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

orkamara
orkamara approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@orkamara orkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

If you can just fix the typo in the PR title... 🥇

@pavel-snyk pavel-snyk changed the title fix: correct isac error import fix: correct iac error import Jul 28, 2020
@lili2311 lili2311 changed the title fix: correct iac error import fix: correct infrastructure as code error import Jul 28, 2020
@lili2311 lili2311 merged commit 12ef8c7 into master Jul 28, 2020
@lili2311 lili2311 deleted the fix/import-correct-isac-error branch July 28, 2020 11:11
@snyksec
Copy link

snyksec commented Jul 28, 2020

🎉 This PR is included in version 1.368.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orkamara orkamara orkamara approved these changes

@pavel-snyk pavel-snyk pavel-snyk approved these changes

@orsagie orsagie Awaiting requested review from orsagie

@MegaBean MegaBean Awaiting requested review from MegaBean

Assignees

@lili2311 lili2311

Labels
released ☠️ tech services
Projects
None yet
Milestone
No milestone
4 participants
@lili2311 @snyksec @orkamara @pavel-snyk