Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: install osslsigncode in release step #1298

Merged
merged 1 commit into from
Jul 28, 2020
Merged

chore: install osslsigncode in release step #1298

merged 1 commit into from
Jul 28, 2020

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Jul 28, 2020

Missing osslsigncode for Windows binary signing

@JackuB JackuB requested a review from pavel-snyk July 28, 2020 15:35
@JackuB JackuB requested review from a team as code owners July 28, 2020 15:35
@ghost ghost requested review from gitphill and orsagie July 28, 2020 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2020 •
edited by JackuB

Expected release notes (by @JackuB)

features:
docker bundle (a745b64)

others (will not be included in Semantic-Release notes):
install osslsigncode in release step (123a5fe)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@snyksec
Copy link

snyksec commented Jul 28, 2020

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 123a5fe

@JackuB JackuB merged commit 8f13109 into master Jul 28, 2020
@JackuB JackuB deleted the chore/add-osslsigncode branch July 28, 2020 17:41
@snyksec
Copy link

snyksec commented Jul 28, 2020

🎉 This PR is included in version 1.369.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-snyk pavel-snyk pavel-snyk approved these changes

@gitphill gitphill Awaiting requested review from gitphill

@orsagie orsagie Awaiting requested review from orsagie

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@JackuB @snyksec @pavel-snyk