fix: transfer classpath via file #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
JackuB
approved these changes
Jul 29, 2020
miiila
force-pushed
the
fix/reachable-classpath-file
branch
from
02f65de
to
2f1ebbd
Compare
darmalovan
approved these changes
Jul 30, 2020
In order to prevent too long command, transfer classpath via a file in using new version of mvn-plugin
miiila
force-pushed
the
fix/reachable-classpath-file
branch
from
2f1ebbd
to
8ac28cd
Compare
|
🎉 This PR is included in version 1.369.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to prevent too long command, transfer classpath through a file in a new version of snyk-mvn-plugin
Where should the reviewer start?
How should this be manually tested?
Use your local installation of snyk and run snyk test/monitor command with --reachable.
Any background context you want to provide?
snyk/snyk-mvn-plugin#77
snyk/java-call-graph-builder#25
snyk/java-call-graph-generator#24
EDIT
One more fix of the fix was added:
snyk/snyk-mvn-plugin#78
snyk/snyk-mvn-plugin#78