Move Danger.js to GitHub Action #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename Smoke test to Regression test as it contains more than just smoke
|
JackuB
force-pushed
the
chore/move-danger-to-gh-action
branch
2 times, most recently
from
7759c46
to
af44bff
Compare
JackuB
force-pushed
the
chore/move-danger-to-gh-action
branch
2 times, most recently
from
1be8d0c
to
bdef87f
Compare
JackuB
force-pushed
the
chore/move-danger-to-gh-action
branch
from
bdef87f
to
2250e94
Compare
ghost
requested review from
pavel-snyk
reviewed
Aug 25, 2020
| name: Danger JS | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 |
There was a problem hiding this comment.
@JackuB , how about add a name for checkout action?
There was a problem hiding this comment.
Don't have a better name for actions/checkout then Checkout ¯\_(ツ)_/¯
pavel-snyk
approved these changes
Aug 25, 2020
|
🎉 This PR is included in version 1.382.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danger.js is having issues running on CircleCI. This will also make it a bit faster.