Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use snyk-gradle-plugin@3.6.2 that sends back project targetFile #1383

Merged
merged 2 commits into from Sep 2, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Sep 2, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Use latest gradle plugin that sends scanned project targetFile as meta

@lili2311 lili2311 requested review from a team as code owners September 2, 2020 10:16
@ghost ghost requested review from ekbsnyk and MegaBean September 2, 2020 10:16
@lili2311 lili2311 requested review from dkontorovskyy and removed request for MegaBean and ekbsnyk September 2, 2020 10:16
@lili2311 lili2311 self-assigned this Sep 2, 2020
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2020

Expected release notes (by @lili2311)

features:
use snyk-gradle-plugin@3.6.2 that sends back project targetFile (5720a16)

fixes:
remove new line to prevent bad spinner clearing (fade21a)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@@ -149,7 +149,7 @@ export function warnSomeGradleManifestsNotScanned(
);

if (diff.length > 0) {
return `✗ ${diff.length}/${detectedGradleFiles.length} detected Gradle manifests did not return dependencies.\nThey may have errored or were not included as part of a multi-project build. You may need to scan them individually with --file=path/to/file. Run with \`-d\` for more info.`;
return `✗ ${diff.length}/${detectedGradleFiles.length} detected Gradle manifests did not return dependencies. They may have errored or were not included as part of a multi-project build. You may need to scan them individually with --file=path/to/file. Run with \`-d\` for more info.`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for this bad clearing of spinner label :(
before
Screen Shot 2020-09-02 at 11 32 47

after
Screen Shot 2020-09-02 at 11 33 33

@lili2311 lili2311 merged commit 945722f into master Sep 2, 2020
@lili2311 lili2311 deleted the feat/bump-gradle-plugin branch September 2, 2020 11:01
@snyksec
Copy link

snyksec commented Sep 2, 2020

🎉 This PR is included in version 1.388.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants