Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add platform details to help for snyk container #1411

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

garethr
Copy link
Contributor

@garethr garethr commented Sep 15, 2020

The snyk container CLI now supports passing an explicit platform value.
This will then test the image with that platform, rather than just the
default (probably amd64).

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds details about --platform to the help text.

How should this be manually tested?

snyk container --help

What are the relevant tickets?

See #1389

The snyk container CLI now supports passing an explicit platform value.
This will then test the image with that platform, rather than just the
default (probably amd64).
@garethr garethr requested review from a team as code owners September 15, 2020 07:50
@ghost ghost requested review from admons and aviadhahami September 15, 2020 07:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2020

Expected release notes (by @garethr)

features:
Add platform details to help for snyk container (565df40)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@garethr garethr merged commit 5bf1e3e into master Sep 15, 2020
@garethr garethr deleted the feat/add-platform-details-to-help branch September 15, 2020 08:53
@snyksec
Copy link

snyksec commented Sep 15, 2020

🎉 This PR is included in version 1.396.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants