Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: runTest jest test, user sees userMessage when generic error occurs #1462

Merged
merged 2 commits into from Oct 19, 2020

Conversation

Avishagp
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@Avishagp Avishagp requested review from a team as code owners October 12, 2020 16:02
@ghost ghost requested review from ekbsnyk and orsagie October 12, 2020 16:02
@Avishagp Avishagp force-pushed the test/runTest-test branch 2 times, most recently from f9b19c7 to 96f37a2 Compare October 13, 2020 15:02
@Avishagp Avishagp changed the title test: add jest test for runTest test: user sees userMessage when generic error occurs, runTest jest test Oct 14, 2020
@Avishagp Avishagp changed the title test: user sees userMessage when generic error occurs, runTest jest test test: runTest jest test, fix generic error throw Oct 14, 2020
@Avishagp Avishagp changed the title test: runTest jest test, fix generic error throw test: runTest jest test, user sees userMessage when generic error occurs Oct 14, 2020
@Avishagp Avishagp force-pushed the test/runTest-test branch 3 times, most recently from 10b05be to 533cbd6 Compare October 18, 2020 07:58
@github-actions
Copy link
Contributor

Expected release notes (by @Avishagp)

features:
better error message propagated if available (e1822cf)

others (will not be included in Semantic-Release notes):
runTest jest test, user-friendly error message (5acc55e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@Avishagp Avishagp merged commit c1b420b into master Oct 19, 2020
@Avishagp Avishagp deleted the test/runTest-test branch October 19, 2020 14:36
@snyksec
Copy link

snyksec commented Oct 19, 2020

🎉 This PR is included in version 1.416.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants