Analytics: track integration environment #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
JackuB
force-pushed
the
feat/track-integration-env
branch
from
829cf19
to
6f0b392
Compare
maxjeffos
approved these changes
Oct 17, 2020
test/analytics-sources.spec.ts
Outdated
| @@ -162,3 +168,41 @@ describe('analytics-sources - getIntegrationVersion', () => { | |||
| ).toBe('1.2.3-Crystal'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('analytics-sources - getIntegrationEnvironment', () => { | |||
| it('integration environment is empty by default', () => { | |||
There was a problem hiding this comment.
Minor nitpick and I'm by no means perfect at this myself (naming is hard), but I understand that one should try to make the describe + the it sort of flow like a sentence. So you could make this
it('returns empty environment by default', () => {
Then you'd have getIntegrationEnvironment returns empty environment by default.
Similarly for the others.
JackuB
force-pushed
the
feat/track-integration-env
branch
from
6f0b392
to
a63850d
Compare
This will help us capture if CLI is running e.g. in a specific IDE version
JackuB
force-pushed
the
feat/track-integration-env
branch
from
a63850d
to
8d4f267
Compare
|
Rebased, simplified the function to always empty empty string instead of undefined, just to be consistent with the |
|
🎉 This PR is included in version 1.419.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us capture debug/analytics data if CLI is running e.g. in a specific IDE version.