feat: paths always shown where available #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
iamtmrobinson
force-pushed
the
feature/paths-always-displayed-when-available
branch
from
0b6645c
to
bbe872a
Compare
|
Expected release notes (by @iamtmrobinson) features:
|
gitphill
approved these changes
Oct 19, 2020
JackuB
approved these changes
Oct 19, 2020
| if ( | ||
| testOptions.showVulnPaths === 'some' && | ||
| paths && | ||
| paths.find((p) => p.length > 2) | ||
| paths.find((p) => p.length > 1) |
There was a problem hiding this comment.
Just curious, should this affect JSON output as well?
There was a problem hiding this comment.
@JackuB off the top of your head, do you know if the JSON output is affected by the --show-vulnerable-paths option?
iamtmrobinson
deleted the
feature/paths-always-displayed-when-available
branch
|
🎉 This PR is included in version 1.421.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently paths for top-level dependencies that have a vuln are only shown if the
allflag is passed to--show-vulnerable-paths. This can be a bit confusing and some people don't understand why they're not seeing an "introduced by:" line for these top-level deps (e.g. if you have a direct dependency ofadm-zip@0.4.7)This PR changes that so that whenever a path is available it will also be shown when the default of
someis used forshow-vulnerable-paths